Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daca se editeaza email-ul userii au probleme sa-si regaseasca profilul #27

Open
alexchiraples opened this issue Aug 6, 2017 · 1 comment

Comments

@alexchiraples
Copy link


Migrated from https://github.com/gov-ithub/volunt-app/issues/30
Originally created by @rusanu on Sat, 26 Nov 2016 10:42:19 GMT


Nu ar trebuii permisa editarea email-ului principal.

@alexchiraples
Copy link
Author


Migrated from https://github.com/gov-ithub/volunt-app/issues/30#issuecomment-263112934
Originally created by @rusanu on Sun, 27 Nov 2016 09:52:59 GMT


Profile email are mai multe probleme. In primul rind nu avem uniquness constaint pe intreg spatiul de email (email in contacts pot fi duplicate intre profile). Si cautarea dupa email (Profile.for_email) cauta dupa tag-uri hard codded (email, email1, email2 si email3). Trebuie separata emails in table proprie, belongs_to :profile si Profile has_many :emails.

Apoi putem adresa si problema de self-update a adresei de email vis-a-vis login. Planul meu era ca un user sa nu-si poata modifica email-ul cu care a facut login. Pentru schimbare de email flow-ul ar fi:

  1. Adauga noul email in profilul personal
  2. Face signout
  3. Face sign-in cu noul email (Update nokogiri ~> 1.8.2 and rails 5.0.7 #31 fixeaza problemele cu sign-in si password reste cu email secundar)
  4. Modifica emailul principal (mai exact, promoveaza noua adresa de email ca 'adresa principala')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant