Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

remove uuid dependency #92

Closed
qiwzhang opened this issue Aug 4, 2017 · 0 comments
Closed

remove uuid dependency #92

qiwzhang opened this issue Aug 4, 2017 · 0 comments
Milestone

Comments

@qiwzhang
Copy link
Contributor

qiwzhang commented Aug 4, 2017

it looks that mixerclient added a dependency on libuuid from
e2fsprogs, which isn't part of base OS (i.e. Goobuntu doesn't have it
installed by default).

However, this dependency wasn't added via Bazel, so the build is
broken and not hermetic at all.

I wanted to make a PR adding libuuid, but it looks that it's licensed
under GPLv2, which means that we cannot statically link against it,
AFAIK.

I think it is from util-linux, yes it is still LGPL, so I think we should remove the dependency.

Envoy has its own uuid impl:
https://github.com/lyft/envoy/blob/master/source/common/runtime/runtime_impl.cc#L28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants