Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

Provide statistics for check and report latencies as histograms #324

Closed
JimmyCYJ opened this issue Jan 3, 2018 · 3 comments
Closed

Provide statistics for check and report latencies as histograms #324

JimmyCYJ opened this issue Jan 3, 2018 · 3 comments
Assignees
@JimmyCYJ

Comments

@JimmyCYJ
Copy link
Member

JimmyCYJ commented Jan 3, 2018

Add Check/Report latency stats as histograms.
@JimmyCYJ JimmyCYJ self-assigned this Jan 3, 2018
@JimmyCYJ JimmyCYJ mentioned this issue Jan 3, 2018
Merged
@qiwzhang
Copy link
Contributor

qiwzhang commented Jan 3, 2018

I think it can be implemented at proxy, use a timer to wrap around the check/report call. Mixerclient doesn't need to do anything. So please move this issue to proxy.

@JimmyCYJ
Copy link
Member Author

JimmyCYJ commented Jan 3, 2018

I have created another issue https://github.com/istio/proxy/issues/893. I am going to close this one. Thanks.

@JimmyCYJ JimmyCYJ closed this as completed Jan 3, 2018
@JimmyCYJ JimmyCYJ reopened this Jan 30, 2018
@JimmyCYJ
Copy link
Member Author

The Mixer stats commits are reverted in #961 due to a segmentation fault issue. Will be checked in once that issue is solved. Reopen this issue for tracking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JimmyCYJ JimmyCYJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qiwzhang @JimmyCYJ