Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

Elevate common request headers to attributes #177

Closed
geeknoid opened this issue Oct 13, 2017 · 4 comments
Closed

Elevate common request headers to attributes #177

geeknoid opened this issue Oct 13, 2017 · 4 comments
Assignees
Milestone

Comments

@geeknoid
Copy link

We need to move common request headers to be first class attributes in order to improve cache efficiency. If the Mixer references any request headers during a Check call, the cache entry ends up being invalidated whenever any request header changes, which is the normal case. This effect completely neutralizes the existing cache.

@geeknoid geeknoid added this to the Istio 0.3 milestone Oct 13, 2017
@qiwzhang
Copy link
Contributor

qiwzhang commented Oct 13, 2017

This will cause data duplication. The right solution is to support string map subkey in ReferencedAttributes.

@geeknoid
Copy link
Author

This can be the long term solution when it is paired with issue #178

@mandarjog
Copy link
Contributor

related to Mixer issue of istio/old_mixer_repo#1099

@geeknoid
Copy link
Author

Since we now handle individual request headers correctly, no need for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants