Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Avoid the use of bookinfo as testing app or enable a way to set custom images #467

Closed
1 task done
fjglira opened this issue Nov 5, 2024 · 3 comments · Fixed by #483
Closed
1 task done
Assignees
Labels
enhancement New feature or request test-e2e

Comments

@fjglira
Copy link
Contributor

fjglira commented Nov 5, 2024

Is this the right place to submit this?

  • This is not a question about how to use the sail-operator

Feature Description

We can test the configuration in the e2e framework by using an alternative containers or adding the possibility to set custom images that can be set by the user to avoid pulling always upstream images to run the test

Additional Information

No response

@fjglira fjglira added enhancement New feature or request test-e2e labels Nov 5, 2024
@fjglira
Copy link
Contributor Author

fjglira commented Nov 8, 2024

Checking the code we use bookinfo app only to validate istio injection, we can change this and use any other app that can allow us to check this and also that can work later as tooling app to validate connection when we is needed, in multicluster test we use sample and sleep app. @FilipB I think I can set a way to set a custom image for those containers and continuing using sleep pod or sample app because we will need this types of apps to validate connectivity in diferents scenarios later. WDYT?

@FilipB
Copy link
Collaborator

FilipB commented Nov 11, 2024

I don't know if we will need to use the sleep app for e2e operator tests in the future. If yes, let's use it. If no, we could test the injection just using a standalone ingress

@fjglira fjglira self-assigned this Nov 15, 2024
@fjglira
Copy link
Contributor Author

fjglira commented Nov 15, 2024

I'll work on this next week. Folks from IBM needed to be able to set their own images, this will leave to the user the possibility to set their own container image for the test run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test-e2e
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants