-
-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Handle whitespace in homedir paths (#98)
Fixes istanbuljs/nyc#784
- Loading branch information
1 parent
1fae96f
commit f002ecc
Showing
2 changed files
with
24 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const IS_WINDOWS = require('is-windows')(); | ||
const tap = require('tap'); | ||
const path = require('path'); | ||
const fs = require('fs'); | ||
|
||
tap.test('spaces in shim-root/homedir path on windows do not break wrapped npm calls', { skip: !IS_WINDOWS }, function(t) { | ||
// create temp folder with spaces in path | ||
process.env.SPAWN_WRAP_SHIM_ROOT = path.join(__dirname, 'fixtures', 'space path'); | ||
|
||
// wrap with custom root path | ||
const sw = require('..'); | ||
const unwrap = sw([]); | ||
|
||
// run a child process with an npm command | ||
const cp = require('child_process'); | ||
const child = cp.exec('npm --version'); | ||
child.on('exit', function(code) { | ||
t.equal(code, 0); | ||
unwrap(); | ||
fs.rmdirSync(process.env.SPAWN_WRAP_SHIM_ROOT); | ||
t.end(); | ||
}); | ||
}); |