Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report has bogus uncovered lines report #35

Closed
aredridel opened this issue Jul 13, 2015 · 9 comments
Closed

Report has bogus uncovered lines report #35

aredridel opened this issue Jul 13, 2015 · 9 comments

Comments

@aredridel
Copy link

Files in .nyc_output are at https://gist.github.com/aredridel/67a635a727047e541c32

Output:

:; nyc report
------------|----------|----------|----------|----------|----------------|
File        |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
------------|----------|----------|----------|----------|----------------|
 __root__/  |    94.92 |    81.13 |      100 |    94.92 |                |
  common.js |    94.37 |    69.23 |      100 |    94.37 | 94,146,150,154 |
  index.js  |    95.74 |    92.59 |      100 |    95.74 |          48,68 |
------------|----------|----------|----------|----------|----------------|
All files   |    94.92 |    81.13 |      100 |    94.92 |                |
------------|----------|----------|----------|----------|----------------|
@bcoe
Copy link
Member

bcoe commented Jul 13, 2015

@aredridel are you running nyc on an open-source project? This could relate to a subprocess we're failing to cover, or a code path that's difficult to hit during the spawning process.

@aredridel
Copy link
Author

@aredridel
Copy link
Author

Oh! That's not a number of uncovered lines. That's a list of them. Geez.

@aredridel
Copy link
Author

I thought it was literally calculating 94 billion uncovered lines.

@aredridel
Copy link
Author

Okay, this is not a bug. This is me misunderstanding the information in that column since it happened to parse as a number with thousands separators.

@bcoe
Copy link
Member

bcoe commented Jul 13, 2015

@aredridel what do you think a better heading would be? a similar issue was here:

gotwarlost/istanbul#390

we should be more clear!

@aredridel
Copy link
Author

If there'd been spaces instead of commas it'd have been clear for me; not sure how that'd be interpreted internationally.

@aredridel
Copy link
Author

"Which lines uncovered" would have made it clear too.

@willhayslett
Copy link

I know this is old, but I ran into this and was so confused. How about "Uncovered Line #'s" or "Uncovered Line Numbers"? "Uncovered Lines" isn't very clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants