Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] broken in test that use mock-fs #246

Closed
thangngoc89 opened this issue May 4, 2016 · 4 comments
Closed

[email protected] broken in test that use mock-fs #246

thangngoc89 opened this issue May 4, 2016 · 4 comments

Comments

@thangngoc89
Copy link

thangngoc89 commented May 4, 2016

I reported this issue before and it was fixed (#205).

But I noticed that in [email protected], the issue comes back. It's fine with [email protected]

See build: https://travis-ci.org/MoOx/phenomic/jobs/127717652

@bcoe
Copy link
Member

bcoe commented May 6, 2016

@thangngoc89 this should be fixed in [email protected].

tldr; we need to figure out a better way to bundle dependencies.

@bcoe bcoe closed this as completed May 6, 2016
@thangngoc89
Copy link
Author

@bcoe Thanks a lot for this. Maybe you can use my test to detect this kind of issue

@bcoe
Copy link
Member

bcoe commented May 6, 2016

@thangngoc89 did this fix things for you?

@thangngoc89
Copy link
Author

@bcoe yes, it did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants