Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watermark is not applied to srcset #2404

Open
cboelter opened this issue Jan 20, 2023 · 2 comments
Open

Watermark is not applied to srcset #2404

cboelter opened this issue Jan 20, 2023 · 2 comments

Comments

@cboelter
Copy link
Contributor

I'm trying to use the watermark function inside the galleries but this is not working if the attribute srcset is set. At the moment isotope only generates a watermarked image for the attribute src: https://github.com/isotope/core/blob/2.8/system/modules/isotope/library/Isotope/Model/Gallery/Standard.php#L386
I think there should be also a handling for the srcsetotherwise for this attribute the original images are used.

If you agree I will be able to create a pull request. My approach would be to split the comma separated list of sources and change the image path with the watermarked path.

@aschempp
Copy link
Member

Shouldn't it be possible to access the list of images before the string is created? Maybe we can influence the image creation directly through the "new" Image methods

@cboelter
Copy link
Contributor Author

I talked to my customer and he deciced to not use the watermark at the moment. If he changed I will able to work on the watermark again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants