Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use h5 tags for site title in footer. #259

Open
Tracked by #265
rc-davis opened this issue Apr 5, 2022 · 0 comments
Open
Tracked by #265

Don't use h5 tags for site title in footer. #259

rc-davis opened this issue Apr 5, 2022 · 0 comments

Comments

@rc-davis
Copy link

rc-davis commented Apr 5, 2022

Google Lighthouse complains about the use of <h5> tags for site titles in page footers. This was highlighted for the NCCS site.

Screenshot 2022-04-05 at 10 43 00 AM

(Lighthouse also complained about the use of an <h3> tag on this page, because there was no <h2> tag, but this happened because the agency started their first heading with ### instead of # or ##, and there's not much we can do about that.)

To observe the problem, go to Settings in the Isomer CMS and set a site's Title. The footer will render the title with an <h5> tags. This can be observed on this test site.

This could be fixed in a variety of ways, such as using a <p> tag with a special class (which is what we do for similar labels in the footer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant