-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): migrate unlinked page tests to playwright #1790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think edit page spec might get quite big + encompass a lot of different types/permutations of editing. Should we consider splitting into markdown editing and tiptap editing?
Also, I think we can separate out the collection + resource room editing into a separate spec that focuses more on testing aspects that are more specific to those types of editing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont have blocking comments for this specific pr, but i do air similar concerns to zj + think we need to cover the edge cases for the two different editors
agreed for |
Yup I think we can add the tiptap ones later. I think we are still in the midst of stablising tiptap so it would be a bit troublesome to create them right now. |
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
640baf0
to
14a83ad
Compare
01f2bf0
to
6ed027b
Compare
Problem
Previously, the tests for editing of unlinked pages were done in cypress. This PR migrates them to playwright. importantly, do take note that there's a shift to testing them on email based login - easier to setup (done alr in prev PR) + majority of our sites are on email based login. (also more complex)
Solution
getApi
method - we need this because we setbaseURL
to be that for our frontend (so that navigation works fine)cypress
selectors toplaywright
locators.