Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(infocols): should not be allowed to rm last #1786

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(infocols): should not be allowed to rm last #1786

merged 1 commit into from
Jan 24, 2024

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Jan 24, 2024 •
edited
Loading

Problem

Bug fix, disable deleting last infobox

Screen.Recording.2024-01-24.at.3.45.24.PM.mov

Tests

  • Navigate to any sites's homepage
  • Add an Infocol
  • Assert that 3 infoboxes are created
  • Delete 2 of the infoboxes
  • Assert that the last infobox cannot be deleted

@kishore03109 kishore03109 requested a review from a team January 24, 2024 07:47
alexanderleegs
alexanderleegs approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, are there any more sites we need to fix this for?

@kishore03109 kishore03109 merged commit 48a33b5 into develop Jan 24, 2024
12 checks passed
@kishore03109
Copy link
Contributor Author

@alexanderleegs actually have good catch!

@mergify mergify bot deleted the fix/infocols branch January 24, 2024 08:57
This was referenced Jan 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore03109 @alexanderleegs