Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.44.0 #1512

Merged
merged 15 commits into from
Sep 21, 2023
Merged

Release/0.44.0 #1512

merged 15 commits into from
Sep 21, 2023

Conversation

harishv7
Copy link
Contributor

Duplicate of #1511

kishore03109 and others added 15 commits September 14, 2023 15:17
@kishore03109
Merge pull request #1493 from isomerpages/release/0.43.0
fbc6711 
0.43.0
@dcshzj
feat(helpers): introduce padding and margin helpers from Tailwind (#1488
2369f25 
)
@dcshzj
fix(contactus): ensure feedback key is present as string (#1501)
2aeeeb1
@dcshzj
fix(styles): introduce site colors as CSS variables (#1503)
0d951b0
@dcshzj
feat(homepage): add preview for announcements component (#1496)
dcf9e97 
* feat(announcements): add SCSS styles from template

* feat(announcements): add frontmatter types

* feat(announcements): introduce preview component

* chore: sync padding and margin helpers

* chore: sync template changes to CMS preview
@dcshzj
chore(announcements): add missing padding for item (#1506)
ea213a3
@seaerchin
feat(herobody): add first pass of layout (#1473)
9411888 
* feat(herobody): add first pass of layout

* feat(herobody): add title/subtitle etc

* fix(herobody): stling

* refactor(herobody): extract icon stuff to funct

---------

Co-authored-by: seaerchin <[email protected]>
Co-authored-by: seaerchin <[email protected]>
@seaerchin
feat(preview): add preview for new homepage variant (#1485)
178edae 
* feat(herobody): update variant in frontmatter

* refactor(herosection): shift to ts

* refactor(herosection): shift stuff out

* refactor(hero): add css and update import

* fix(hero): style fixes

* fix(heorbody): update colours

* refactor(herobody): use icon

* refactor(hero): remove gray overlay on image only layout

* fix(homepagepreview): add default if no variant

* fix(use): shifted to previewpanel

* fix(herodropdown): add missinng default

---------

Co-authored-by: seaerchin <[email protected]>
@seaerchin
feat(homepage): add previews for side layout (#1490)
de687ad 
* refactor(hero): shift padding out

* feat(styles): add new css

* refactor(template-hero-banner): update existing styles

* feat(hero): add new types

* feat(hero): add new components for template

* refactor(types): update hero + homepage types

* refactor(hero): update preview

* refactor(herosidelayoiut): extract to name

* feat(herobody): add tooltip

* fix(herosidelayout): use bg color for mobile

* refactor(herobody): use known types

* refactor(herobody): removed dead code + update naming

* fix(herosidelayout): removed href from a tags

---------

Co-authored-by: seaerchin <[email protected]>
Co-authored-by: seaerchin <[email protected]>
@seaerchin
feat(hero-section): adds dropdown (#1491)
ae6b074 
* feat(hero): add dropdown

* fix(herosdielayout): cneter dropdown in desktop

---------

Co-authored-by: seaerchin <[email protected]>
Co-authored-by: seaerchin <[email protected]>
@dcshzj
chore(imports): standardize way to import image assets (#1509)
4ec6618
@seaerchin
feat(heroimageonlylayout): add dropdown (#1494)
6640ac5 
* feat(heroimageonlylayout): add dropdown

* feat(heromiageonlylayout): add css

---------

Co-authored-by: seaerchin <[email protected]>
Co-authored-by: seaerchin <[email protected]>
@seaerchin
feat(homepage): add floating variant (#1498)
3221187 
* feat(floating): add floating variant

* refactor(herobutotn): shift out

---------

Co-authored-by: seaerchin <[email protected]>
@seaerchin
feat(flags): add feature flag (#1507)
90ae047 
Co-authored-by: seaerchin <[email protected]>
@harishv7
0.44.0
f08ce4e
@mergify mergify bot mentioned this pull request Sep 20, 2023
Merged
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:27 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:28 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:29 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:29 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:39 — with GitHub Actions Inactive
@cypress
Copy link

cypress bot commented Sep 20, 2023

25 failed tests on run #331 ↗︎

25 138 1 15 Flakiness 0

Details:

Release/0.44.0
Project: isomercms-frontend Commit: f08ce4e146
Status: Failed Duration: 34:45 💡
Started: Sep 20, 2023 10:32 AM Ended: Sep 20, 2023 11:07 AM
Failed  collaborators.spec.ts • 3 failed tests

View Output Video

Test Artifacts
collaborators flow > Admin adding a collaborator > should be able to add a collaborator Output Screenshots Video
collaborators flow > Admin removing a collaborator > should be able to remove an existing collaborator Output Screenshots Video
collaborators flow > Admin removing a collaborator > should not be able to remove the last site member Output Screenshots Video
Failed  comments.spec.ts • 1 failed test

View Output Video

Test Artifacts
Comments > no access rights > should not be able to create comments for a site which one is not a site member Output Screenshots Video
Failed  editPage.spec.ts • 3 failed tests

View Output Video

Test Artifacts
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add untrusted external scripts Output Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add inline scripts Output Screenshots Video
editPage.spec > Edit resource page > Edit page (resource) should have correct colour Output Screenshots Video
Failed  homepage.spec.ts • 6 failed tests

View Output Video

Test Artifacts
Homepage > Block editing > should display the site notification correctly Output Screenshots Video
Homepage > Block editing > should only allow up to 4 highlights for the hero section Output Screenshots Video
Homepage > Block editing > should remove the button in preview when the hero button content is not given Output Screenshots Video
Homepage > Block editing > should preserve content when swapping between highlights and dropdown for hero section Output Screenshots Video
Homepage > Block editing > should limit users to a single resource component Output Screenshots Video
Homepage > Block editing > should rearrange the blocks correctly and the preview should also reflect the new order Output Screenshots Video
Failed  images.spec.ts • 1 failed test

View Output Video

Test Artifacts
Images > Create image, delete image, edit image settings, and move images in image albums > Should be able to move image to different image album Output Screenshots Video

The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@harishv7 harishv7 merged commit 4fa811a into master Sep 21, 2023
28 of 29 checks passed
@mergify mergify bot deleted the release/0.44.0 branch September 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore03109 kishore03109 kishore03109 approved these changes

@alexanderleegs alexanderleegs Awaiting requested review from alexanderleegs

@dcshzj dcshzj Awaiting requested review from dcshzj

@seaerchin seaerchin Awaiting requested review from seaerchin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harishv7 @kishore03109 @dcshzj @seaerchin