Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.44.0 #1511

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Release/0.44.0 #1511

merged 1 commit into from
Sep 21, 2023

Conversation

harishv7
Copy link
Contributor

v0.44.0

  • feat(flags): add feature flag #1507
  • feat(homepage): add floating variant #1498
  • feat(heroimageonlylayout): add dropdown #1494
  • chore(imports): standardize way to import image assets #1509
  • feat(hero-section): adds dropdown #1491
  • feat(homepage): add previews for side layout #1490
  • feat(preview): add preview for new homepage variant #1485
  • feat(herobody): add first pass of layout #1473
  • chore(announcements): add missing padding for item #1506
  • feat(homepage): add preview for announcements component #1496
  • fix(styles): introduce site colors as CSS variables #1503
  • fix(contactus): ensure feedback key is present as string #1501
  • feat(helpers): introduce padding and margin helpers from Tailwind #1488
  • 0.43.0 #1493

@harishv7 harishv7 mentioned this pull request Sep 20, 2023
@mergify
Copy link

mergify bot commented Sep 20, 2023

⚠️ The sha of the head commit of this PR conflicts with #1512. Mergify cannot evaluate rules on this PR. ⚠️

@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:27 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:28 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:29 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:29 — with GitHub Actions Inactive
@harishv7 harishv7 temporarily deployed to staging September 20, 2023 10:39 — with GitHub Actions Inactive
@harishv7
Copy link
Contributor Author

harishv7 commented Sep 20, 2023

@harishv7

  • feat(flags): add feature flag chore(hero): add feature flag for hero banner #1507

    • go to an actual production site from our agency (<- we want to guarantee that there's no template related changes made)
    • expand hero section
    • should not have single select for toggling variant
  • feat(heroimageonlylayout): add dropdown feat(heroimageonlylayout): add dropdown #1494

    • select image only variant for hero section
    • select dropdown for hero interactions
    • there should be a dropdown in preview
    • update options/title -> preview should also update
    • repeat in diff screen sizes
  • feat(homepage): add previews for side layout feat(homepage): add previews for side layout #1490

    • go to homepage
    • select side variant
    • the preview should update with default options
    • select the various options
    • the preview should update correctly
    • update to either highlight/dropdown for hero interaction
    • preview should update correctly

@kishore03109

  • feat(homepage): add floating variant feat(homepage): add floating variant #1498

    • select floating variant
    • preview should update
    • select dropdown for hero interaction
    • update options/title
    • change order
    • preview should update
    • do the same for highlight
    • chnage order
    • preview should update
    • repeat on diff screen sizes
    • preview also shud update
  • feat(hero-section): adds dropdown feat(hero-section): adds dropdown #1491

    • Go to the hero section
    • select the side variant
    • select dropdown
    • the options there should be preserved, and the preview should be updated
    • change the dropdown options/title
    • the preview should also update accordingly
    • try this in different view ports (technically we don't support)
  • feat(herobody): add first pass of layout feat(herobody): add first pass of layout #1473

    • go to homepage
    • click on the hero section
    • select the various new layouts
    • the panel should reflect the new options
    • the preview should not work
  • fix(contactus): ensure feedback key is present as string fix(contactus): ensure feedback key is present as string #1501

    • Navigate to a site where the _data/footer.yml file has a null feedback key (i.e. feedback: )
    • Visit the Contact Us page
    • Make any change, the page should save successfully (previously it cannot save)

No Tests Required

chore(imports): standardize way to import image assets #1509 - no tests, chore fix

#1496 - No tests are currently available, as the announcements component can only be previewed once the left sidebar is updated to support editing of the new announcements component.

feat(helpers): introduce padding and margin helpers from Tailwind #1488

To be tested in next release

@seaerchin

  • fix(styles): introduce site colors as CSS variables fix(styles): introduce site colors as CSS variables #1503

    • Visit any site's homepage
    • See that the --site-primary-color, --site-secondary-color and --site-secondary-color-hover variables are defined in the root element
  • feat(preview): add preview for new homepage variant feat(preview): add preview for new homepage variant #1485

    • go to the homepage
    • click on hero
    • change the variant from center to image only
    • the preview should update
    • there should be only the button + highlight
    • updating highlights should also update preview (title, add highlights, reorder)
    • drop-down added in later PR but if it's also in then
    • update to drop-down interaction
    • preview should also update
    • change the dropdown (title, add dropdown, reorder)
    • the preview should also update

@harishv7 harishv7 merged commit bd48df4 into develop Sep 21, 2023
28 of 29 checks passed
@mergify mergify bot deleted the release/0.44.0 branch September 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants