Fix/edit nav nits #1476
Merged
Fix/edit nav nits #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
dcshzj
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
No issues with the styling changes, but @alexanderleegs can check for the delete buttons, I realised yours isn't 100% width, should it be the full width or just the current width (which is based on the text)?
alexanderleegs
force-pushed
the
fix/edit-nav-nits
branch
from
e267028 to
35f1671
Compare
Checked with design - we'll leave it as is! |
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
added a commit
that referenced
this pull request
Sep 7, 2023
* fix: reduce bottom padding of sidebar * fix: text styling * fix: padding on add section button * chore: remove periods from validators * chore: change placeholder text * fix: update default values of new sections * fix: copy changes
alexanderleegs
added a commit
that referenced
this pull request
Sep 7, 2023
* fix: reduce bottom padding of sidebar * fix: text styling * fix: padding on add section button * chore: remove periods from validators * chore: change placeholder text * fix: update default values of new sections * fix: copy changes
alexanderleegs
added a commit
that referenced
this pull request
Sep 7, 2023
* feat: re-introduce comment-based trigger for Chromatic (#1468) * chore(contactus): styling fixes based on design feedback (#1470) * chore(contactus): styling fixes based on design feedback * fix: use subhead-1 styling instead * chore: remove unused import * Chore/fix edit nav bar styles (#1466) * fix: nav menu template styles * fix: add spacing for legacy nav section * chore: remove unused attributes * chore: move flex into className * Chore/fix title text (#1472) * chore: fix title text * chore: fix other instances of spacing * fix(edithomepage): spread properly (#1474) Co-authored-by: seaerchin <[email protected]> * Fix/edit nav nits (#1476) * fix: reduce bottom padding of sidebar * fix: text styling * fix: padding on add section button * chore: remove periods from validators * chore: change placeholder text * fix: update default values of new sections * fix: copy changes * fix(homepage): various styling fixes (#1477) * fix(edithomepage): fixed spacing between card/button * fix(editable): fixed styling * fix(editable): updated padding of editable accordion button * fix(hero-highlight): fixed copy * fix(editable): update padding * fix(hero-higihlihgt-section): update wording * refactor(formmediainput): add width * fix(editable): fixed border radius on hover --------- Co-authored-by: seaerchin <[email protected]> * feat(editable): introduce new nested card variant (#1478) * feat(icons): introduce new vertical draggable icon * feat(editable): introduce nested version of accordion * fix(contactus): update location card to use nested * fix: border radius of error divider * 0.42.0 --------- Co-authored-by: seaerchin <[email protected]> Co-authored-by: Hsu Zhong Jun <[email protected]> Co-authored-by: seaerchin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves Nav specific issues in https://www.notion.so/opengov/Restyling-feedback-3a4dc84523ff44529e0644ae85b4e0ca.
Resolves IS-533