feat(herobody): add first pass of layout #1473
Conversation
seaerchin
force-pushed
the
feat/is-450-hero-banner-panel
branch
from
591fa75 to
81d9bf2
Compare
|
ps, missing 1 title/subtitle on side layuot - adding now |
seaerchin
force-pushed
the
feat/is-450-hero-banner-panel
branch
from
af1bad8 to
2686bb0
Compare
| size="half" | ||
| alignment="left" | ||
| backgroundColor="black" |
There was a problem hiding this comment.
This resets the values every time the user selects a different option then comes back - are we okay with this behaviour?
There was a problem hiding this comment.
this is gonna be fixed in an upcoming PR - we're gonna roll out the new stuff totally (behind a feature flag) so this intermediate state won't be seen
| alignment = "left", | ||
| backgroundColor = "black", | ||
| }: HeroSideSectionProps) => { | ||
| const [, setSectionSize] = useState(size) |
There was a problem hiding this comment.
why do we need the set state without declaring the state?
There was a problem hiding this comment.
ps, i only added the panel - this means that the preview stuff here isn't working (it's a stop gap).
the actual preview component for these are gonna be added in a follow up and htis will be removed
| <Box w="100%"> | ||
| <Text textStyle="subhead-1">Section background colour</Text> | ||
| <HStack spacing="0.75rem" alignItems="flex-start"> | ||
| <IconButton |
There was a problem hiding this comment.
maybe can store as [{}] and .map
There was a problem hiding this comment.
ps, could you go into a bit more detail her?
There was a problem hiding this comment.
thisis a nit: I see we are doing 3 times.
Instead can define the properties above as array of objects and then map over it. Might be neater
There was a problem hiding this comment.
i will put as a function cos it relies on the icon colour (black/gray/white)
seaerchin
force-pushed
the
feat/is-450-hero-banner-panel
branch
from
d55f14e to
4ce3229
Compare
Problem
we need to add new layout options for hero banner
Solution
Screenshots
Tests