Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update reviewId to prNumber #1130

Open
dcshzj opened this issue Oct 21, 2022 · 0 comments
Open

[Fix] Update reviewId to prNumber #1130

dcshzj opened this issue Oct 21, 2022 · 0 comments

Comments

@dcshzj
Copy link
Contributor

dcshzj commented Oct 21, 2022

There are some parts of the codebase that uses reviewId to query a particular entry in the ReviewRequests table. This is not ideal, as a review request should be identified by the composite primary key of the site name and the pull request number found on GitHub. The reviewId should only be used within the database, or when the siteName and prNumber information is not available.

The URLs used on both the frontend and backend uses the pull request number. Any instances that uses this information should be renamed to prNumber so that it is clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant