Symbols in az-cli generated clientSecret breaks login

[ishitachawla]

Following this guide, most people probably just copy&paste the JSON output generated by the service principal creation via az-cli to their Github secrets.

However the generated clientSecret often contains symbols which must be escaped in order to work in the az login command performed in the Github Action.

For example:
az-cli generated a clientSecret which includes avc!bH9;5<d9L,M!.
This breaks the login process without a meaningful error mesasge. It works if it's escaped to avc!bH9;5<d9L,M! before being inserted here:

executeAzCliCommand(`login --service-principal -u "${servicePrincipalId}" -p "${servicePrincipalKey}" --tenant "${tenantI