Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP address matching not entirely correct #1

Open
geniass opened this issue Aug 15, 2018 · 0 comments
Open

IP address matching not entirely correct #1

geniass opened this issue Aug 15, 2018 · 0 comments

Comments

@geniass
Copy link
Contributor

geniass commented Aug 15, 2018 •
edited
Loading

e.g. if

allowedIps = 192.168.1.10,127.0.0.1

and the external IP happens to be

192.168.1.1

This would match successfully.

This requires a better regex, or maybe splitting allowedIps on commas and checking for exact matches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geniass