Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create draft keyboard navigation event content #8

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Conversation

isabela-pf
Copy link
Owner

The long-awaited second event type is being prototyped! 🎉

This PR introduces some (very) draft resources for testing out an event for reviewing keyboard navigation and contributing a review document to identify issues. This could be run on a whole interface, on a PR (with permission), probably even on desktop apps.

While it doesn't directly fix all the issues, this lack of review knowledge in the broader community has meant that lots of work passes through review missing some foundational accessibility needs. The tests listed in review-template.md may be helpful for reviewers even outside of event contexts. 🌻

This PR:

  • Creates a new directory workshop-resources/keyboard-navigation
  • Adds a README.md to describe keyboard navigation events and index the resources
  • Adds an agenda-template.md as an incomplete event agenda
  • Adds a review-template.md to provide the main content and document participants will contribute to during the event

Phew. 😅 There's a lot in these three files, but the review-template.md is the only entirely new piece of content. The rest are based on the image description event resources.

7.
8.
9.
10.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sign in area seems like a branch conflict nightmare waiting to happen. I would like to find a way for participants to voluntarily sign in and get clear credit for their work whether or not they get to writing a full review for commit, so this is the placeholder.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remains a problem in the latest commit.


| Area | Able to navigate to the area (yes/no/not applicable) | Able to navigate fully within the area (yes/no/not applicable) | Able to navigate out of the area (yes/no/not applicable) |
|---|---|---|---|
| Menu bar | a | b | c |
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, these are web app related! Would it make sense to have them be more general by using HTML sections?

At best, these sections match the website architecture. At worst, the sections provide a mental model for talking about poor or non-HTML implementations that has been heavily tested.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've retemplated this to sort of match the patterns of HTML sections in How to Section Your HTML and HTML Standard for Sectioning content.

@isabela-pf
Copy link
Owner Author

@isabela-pf
Copy link
Owner Author

I'm going to merge this since I haven't gotten further feedback. I'm expecting many changes will need to be made as this event starts getting tested. Onwards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant