From 40e1d612d3d58e415362b1ebb97df8b69da5374f Mon Sep 17 00:00:00 2001 From: isaacs Date: Mon, 23 Sep 2019 11:47:30 -0700 Subject: [PATCH] remove undocumented 'ended' getter Caused a regression in any modules using 'ended' themselves. --- index.js | 4 ---- test/basic.js | 1 - 2 files changed, 5 deletions(-) diff --git a/index.js b/index.js index 5780ef1..215dc62 100644 --- a/index.js +++ b/index.js @@ -335,10 +335,6 @@ class Minipass extends EE { return this[EMITTED_END] } - get ended () { - return this[EMITTED_END] - } - [MAYBE_EMIT_END] () { if (!this[EMITTING_END] && !this[EMITTED_END] && diff --git a/test/basic.js b/test/basic.js index 5d6a9ec..c6851f3 100644 --- a/test/basic.js +++ b/test/basic.js @@ -196,7 +196,6 @@ t.test('write after end', async t => { mp.on('end', _ => sawEnd++) mp.end() // empty t.ok(mp.emittedEnd, 'emitted end event') - t.ok(mp.ended, 'emitted end event') t.throws(_ => mp.write('nope')) t.equal(sawEnd, 1, 'should get end event (empty stream)') mp.resume()