Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 12-hour time formats #25

Closed
irvinlim opened this issue Oct 4, 2024 · 2 comments · Fixed by #26
Closed

Support 12-hour time formats #25

irvinlim opened this issue Oct 4, 2024 · 2 comments · Fixed by #26

Comments

@irvinlim
Copy link
Owner

irvinlim commented Oct 4, 2024

Currently the timestamp parsing fails if the user's phone is set to 12-hour in region settings. Additionally, it looks like 12-hour time may contain non-breaking spaces between the hour and the AM/PM, like as follows:

"2024-09-21 7:57:00\xe2\x80\xafam +1000"

The non-breaking space is a change in the ICU package: https://icu.unicode.org/download/72

Ref: #24 (comment)

@irvinlim irvinlim changed the title Support 12-hour time locales Support 12-hour time formats Oct 4, 2024
@tedpearson
Copy link
Collaborator

I'm curious how you traced it to the ICU package change. Care to share?

@irvinlim
Copy link
Owner Author

I'm curious how you traced it to the ICU package change. Care to share?

Oh actually I simply tried to Google around for e280af, and that brought me to this issue: nodejs/node#46123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants