Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature suggestion] Duplicate registration of the same account should be rejected with an informative message #1603

Open
yurivict opened this issue Jul 17, 2016 · 3 comments

Comments

@yurivict
Copy link

Some people might copy the account files and run it on different devices (no multi-device support yet). In such case devices chaotically register/unregister, possibly kicking each other out. Other users see such account as going online/offline many times. I observed this behavior before, and again today (qTox/qTox#3525).

I suggest Tox should reject the duplicate account registrations with the message to user, possibly stating the IP address/time/any available information about the previous registration. Such condition may be caused by lost/stolen account/device, or simply by the copied account.

Rejecting the duplicate registration with an informative message is much better and safer behavior rather than what happens now. User will also know that something is wrong, vs. probably not noticing the problem as it is now.

@yurivict yurivict changed the title [feature suggestion] Duplicate registration of the same account should be rejected with the meaningful message [feature suggestion] Duplicate registration of the same account should be rejected with an informative message Jul 17, 2016
@GrayHatter
Copy link
Collaborator

Doing so would prohibit you from reconnecting if you have a spotty internet connection

@LittleVulpix
Copy link
Contributor

I do agree that this is an issue because if it happens, you generally have no way of telling the user to sort it out - because they will constantly flap between offline and online; and if any messages do get through, they will arrive on random of the two clients. A difficult thing to solve indeed...

@yurivict
Copy link
Author

Maybe DHT should keep a state for a while and ban reregistration when done from the same host over and over again within seconds, but allow reregistration from the new IP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants