Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test Coverage #17

Closed
ArminFirecracker opened this issue Mar 16, 2018 · 2 comments
Closed

Unit Test Coverage #17

ArminFirecracker opened this issue Mar 16, 2018 · 2 comments
Assignees

Comments

@ArminFirecracker
Copy link

We at http://www.brainproducts.com/ thinking of using OpenMcdf for our next project. So I had a deeper look into the functionality and I'm quite happy!

There are some parts of the code not covered by the unit test. I wonder if you are aware of that.

Like this method:

public CompoundFile(Stream stream, CFSUpdateMode updateMode, CFSConfiguration configParameters)

@ironfede ironfede self-assigned this Mar 16, 2018
@jeremy-visionaid
Copy link
Collaborator

@ArminFirecracker as part of #194 I've been looking to extend the test coverage. Coverlet currently shows about 80% coverage of the core library. I'd like to get to the point where at least all the public methods are invoked by unit tests, at which point I'd consider this closed.

@jeremy-visionaid
Copy link
Collaborator

Unit test coverage is now at ~90% and covers the full public API surface for v3.0. Most of the remaining code is for interface implementations that happen to be unused and a few corner cases for corrupt data structures. Eventually it would be nice to have tests for the corrupt data strucutres, but I think enough has been done to close this ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants