Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network peering status #189

Closed
afritzler opened this issue Mar 8, 2024 · 3 comments · Fixed by #217
Closed

Network peering status #189

afritzler opened this issue Mar 8, 2024 · 3 comments · Fixed by #217
Assignees
Labels
enhancement New feature or request

Comments

@afritzler
Copy link
Member

Summary

Do we currently have a way to determine the status of a Network peering? E.g. when a peering between two networks has been successful or failed? Currently the Network type has no peering related Status information.

@guvenc
Copy link
Collaborator

guvenc commented Mar 8, 2024

No, we dont have. This needs to be enhanced.

@guvenc guvenc moved this to Todo in Networking Mar 13, 2024
@kasabe28
Copy link
Contributor

kasabe28 commented Apr 17, 2024

We can add this with below approach:

  • Introduce NetworkPeeringStatus Network type with 2 fields:
    1. ID : peered network ID. It can be used by metalnetlet to sync peering status from metalnet.
    2. State: peering state will be either Pending or Applied
  • while reconciling peered vnis of network, update the peering state based on subscription state.

@guvenc
Copy link
Collaborator

guvenc commented Apr 17, 2024

@kasabe28 I think Applied could be a bit misleading. (applied but is it ready ? )
Possible values Ready, Pending and Error sound better to me. (and conform to other object states in metalnet)
ID field sounds good.

@ushabelgur ushabelgur self-assigned this Apr 22, 2024
@ushabelgur ushabelgur moved this from Todo to In Progress in Networking Apr 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Networking May 2, 2024
@guvenc guvenc moved this from Done to Archive in Networking May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Archive
Development

Successfully merging a pull request may close this issue.

4 participants