Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate usage of SetupSignalHandler() in manager setup #259

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

balpert89
Copy link
Contributor

Fixes #258

@balpert89 balpert89 requested a review from a team as a code owner March 11, 2024 12:26
@github-actions github-actions bot added bug Something isn't working size/XS labels Mar 11, 2024
@afritzler afritzler changed the title fix superfluous call to SetupSignalHandler() Remove duplicate usage of SetupSignalHandler() in manager setup Mar 11, 2024
@afritzler afritzler merged commit a2da3f1 into main Mar 11, 2024
11 checks passed
@afritzler afritzler deleted the fix/setup-signal-handler-called-twice branch March 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic during bootstrap of controller-manager due to second call to controllerruntime.SetupSignalHandler()
2 participants