Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add upsert entrypoint for route updates #288

Closed
ucirello opened this issue Nov 15, 2016 · 3 comments
Closed

api: add upsert entrypoint for route updates #288

ucirello opened this issue Nov 15, 2016 · 3 comments

Comments

@ucirello
Copy link
Contributor

Currently we can only issue POST (create), DELETE and and GET to Routes. So whenever faced with the need to update a route, we are forced to do a delete-then-create for the routes; triggering service disruption during interfaces.

fnctl takes this approach for now - and fixing this issue must also change its source code.

It relates to #259 and its related issues.

@ucirello
Copy link
Contributor Author

cc @pedronasser

@ucirello
Copy link
Contributor Author

cc @denismakogon

@ucirello ucirello added this to the Alpha 2 milestone Nov 15, 2016
@ucirello
Copy link
Contributor Author

ucirello commented Nov 16, 2016

Commenting these lines out: https://github.com/iron-io/functions/blob/master/fnctl/routes.go#L340-L342

And running:

./fnctl routes config set myapp hello key1 value1
./fnctl routes config set myapp hello key2 value2

the key2/value2 pair will not be there.

In the logs, you should get a "error=Route already exists"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants