Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port histogram re-binning to main #166

Closed
alexander-held opened this issue Jun 28, 2023 · 4 comments · Fixed by #197
Closed

Port histogram re-binning to main #166

alexander-held opened this issue Jun 28, 2023 · 4 comments · Fixed by #197
Assignees
Labels
implementation concerns analysis implementation

Comments

@alexander-held
Copy link
Member

alexander-held commented Jun 28, 2023

Port over #165 (and eventually replace by a cabinetry-native method) to main after #158 is merged.

The lower bin edge shift from 120j -> 110j should not only be done in the histogram saving but also in the notebook visualization.

@alexander-held alexander-held self-assigned this Jun 28, 2023
@alexander-held alexander-held added the implementation concerns analysis implementation label Jun 28, 2023
@alexander-held alexander-held changed the title Port histogram re-binning to main` Port histogram re-binning to main Jun 28, 2023
@alexander-held
Copy link
Member Author

In the context of this update (which will change histograms) it would be useful to also fix the inconsistent use of >= / > for b-tagging cuts as pointed out by @eguiraud:

selections.add("exactly_1b", ak.sum(jets.btagCSVV2 >= B_TAG_THRESHOLD, axis=1) == 1)
selections.add("atleast_2b", ak.sum(jets.btagCSVV2 > B_TAG_THRESHOLD, axis=1) >= 2)

@eguiraud
Copy link
Contributor

Pointed out by @andriiknu actually 😬

According to the spec it should be > everywhere: https://agc.readthedocs.io/en/latest/versionsdescription.html

@alexander-held
Copy link
Member Author

#174 is dedicated to tracking the b-tagging.

@alexander-held
Copy link
Member Author

While doing this (which will trigger the need for new reference histograms), also remove the offsetting by 1e-6 in

for channel in channel_names:
hist_dict[channel] += 1e-6
(this was a workaround to avoid issues due to empty bins for the statistical inference stage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation concerns analysis implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants