Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rules 417 and 418 which enforce sequential indexing for poles and zeros. #102

Closed
timronan opened this issue Apr 21, 2020 · 2 comments
Closed

Comments

@timronan
Copy link
Collaborator

timronan commented Apr 21, 2020

Error: 417
IF Stage[N]:PolesZeros contains Zeros then Zero:Number must start at 0 and be sequential.

Error: 418
IF Stage[N]:PolesZeros contains Poles then Pole:Number must start at 0 and be sequential.

We are proposing to add the rule listed above. Please comment with any feedback.

@timronan timronan changed the title Add Rules 417 and 418 which enforce sequential indexing fo poles and zeros. Add Rules 417 and 418 which enforce sequential indexing for poles and zeros. Apr 21, 2020
@timronan
Copy link
Collaborator Author

Rules 417 and 418 were combined into rule:

417: If Stage[N]:PolesZeros contains Zeros and Poles then Zero:Number and Pole:Number must start at 0 and be sequential.

This rule has been included by commit 93638a5.

@SCEDC
Copy link

SCEDC commented May 7, 2020

We would like to request this rule not be implemented in the validator. (on behalf of SIS development team)

First of all, the order of poles and zeros does not matter when calculating the response of a channel.

Secondly, the number attribute in FDSN StationXML is optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants