-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main -> google #5500
Merged
Merged
Merge main -> google #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only half plumbed through before and now it's about 85% plumbed. Probably.
This allows applications to inject a set of static libraries that can be resolved at runtime by name. This only includes the runtime portion: there's nothing in the compiler actually generating static libraries yet. Future improvements to the driver API as part of iree-org#4298 will make it easier to inject these loaders. Fixes iree-org#4679.
iree-org#5493 can return the inlining behavior once we have better ringbuffer support and can measure the benefits.
Adding support for !vm.list<?> variant types.
Previously they were assuming the entire underlying storage buffer was equal to the valid byte length which caused problems now that we are packing multiple buffers together.
I'm suspicious that this is the proximate cause of crashes we're seeing while destroying the Vulkan device. We think iree-org#2659 and iree-org#2900 are the root cause, but reverting for now to try to get us back to green. Example failure, starting at the PR being reverted: https://source.cloud.google.com/results/invocations/a3093172-ae55-43bb-956c-256bb726006f/targets/iree%2Fgcp_ubuntu%2Fcmake-bazel%2Flinux%2Fx86-turing%2Fmain/log Reverts iree-org#5467
…org#5494) This required a minor tweak to start_as_root the flatbuffer root tables prior to recording any data. This was discovered thanks to the gracious help (and patience) of of the flatcc author: dvidelabs/flatcc#179 With this all of our binary blobs embedded into the flatbuffers are now 16-byte aligned with the option to tweak it further via a vm.rodata attribute. We don't need utf8 strings to be 16-byte aligned, for example.
…-things Force all constants to be outlined and stored in the constant pool.
b0e2852 Merge pull request iree-org#5491 from rsuderman:main-to-google 3d9cd12 Synchronize submodules with LLVM at llvm/llvm-project@bb907b2 d23d2c5 Synchronize submodules with LLVM at llvm/llvm-project@bb907b2 7067b1e Integrate LLVM at llvm/llvm-project@bb907b2 efd715f Integrate LLVM at llvm/llvm-project@3bc88eb 8012dcd Integrate LLVM at llvm/llvm-project@3f97c66 e8f0247 Merge pull request iree-org#5466 from rsuderman:main-to-google 99ea45f Integrate LLVM at llvm/llvm-project@f28cb01
- This is currently a NOP
Merged
GMNGeoffrey
added a commit
that referenced
this pull request
Apr 19, 2021
* 0adee0f Merge pull request #5520 from GMNGeoffrey:main-to-google * e302cb3 Synchronize submodules with LLVM at llvm/llvm-project@80e166f81abd * 6c94570 Integrate LLVM at llvm/llvm-project@80e166f81abd * ce364ae Integrate LLVM at llvm/llvm-project@517c3aee4de5 * 32792f7 Merge pull request #5500 from rsuderman:main-to-google
This was referenced Apr 20, 2021
Closed
Merged
GMNGeoffrey
added a commit
that referenced
this pull request
Apr 22, 2021
* 97a7c8e Synchronize submodules with LLVM at llvm/llvm-project@2f69975683f5 * 3c09f24 Integrate LLVM at llvm/llvm-project@2f69975683f5 * 44d1063 Merge pull request #5551 from GMNGeoffrey:main-to-google * 1243070 Integrate LLVM at llvm/llvm-project@1a3f88658a02 * 361e47b Integrate LLVM at llvm/llvm-project@4bb60c285cb3 * eaeb09d Integrate LLVM at llvm/llvm-project@9430efa18b02 * dc0af0c Synchronize submodules with LLVM at llvm/llvm-project@e0adf7e06a9e * 678b1e1 Integrate LLVM at llvm/llvm-project@e0adf7e06a9e * 98cf087 Integrate LLVM at llvm/llvm-project@01ace074fcb6 * 307cef0 Integrate LLVM at llvm/llvm-project@aa80ea8a617b * 297f730 Integrate LLVM at llvm/llvm-project@fb69b92c7b33 * 5f1f4fe Integrate LLVM at llvm/llvm-project@f549176ad976 * bda62f0 Merge main -> google * 0adee0f Merge pull request #5520 from GMNGeoffrey:main-to-google * e302cb3 Synchronize submodules with LLVM at llvm/llvm-project@80e166f81abd * 6c94570 Integrate LLVM at llvm/llvm-project@80e166f81abd * ce364ae Integrate LLVM at llvm/llvm-project@517c3aee4de5 * 32792f7 Merge pull request #5500 from rsuderman:main-to-google
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm.rodata
and use it in flatbuffers. (Specify an alignment onvm.rodata
and use it in flatbuffers. #5494)