Reapply "[Codegen][GPU] Add range information to GPU dispatch IDs" (#19361) #19372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysz00
force-pushed
the
gpu-id-ranges-2
branch
from
a6ba1ba to
780b2ab
Compare
krzysz00
requested review from
antiagainst,
MaheshRavishankar,
kuhar,
qedawkins,
Groverkss and
benvanik
as code owners
benvanik
reviewed
Dec 12, 2024
| def HAL_InterfaceWorkgroupIDOp : HAL_PureOp<"interface.workgroup.id", [ | ||
| DeclareOpInterfaceMethods<OpAsmOpInterface, ["getAsmResultNames"]>, | ||
| ]> { | ||
| class HAL_InterfaceWorkgroupOp<string mnemonic, list<Trait> traits = []> |
benvanik
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
LGTM for HAL changes! may want @MaheshRavishankar or someone to take a peek at the codegen side.
qedawkins
approved these changes
Dec 12, 2024
krzysz00
force-pushed
the
gpu-id-ranges-2
branch
from
780b2ab to
dbba7fa
Compare
kuhar
reviewed
Dec 12, 2024
…ree-org#19361) This reverts commit cb5be1d. Compaled to the previous revision, this one works around a correctness bug in dataflow analysis that's being fixed by removing the analysis after SCF->CF. --- First, this patch implements InferIntRangeInterface for hal.interface.workgroup.{size,id,count} using a local upper_bound attribute. Then, it adds a -iree-codegen-gpu-propagate-dispatch-size-bounds pass that adds these upper_bounds identifiers to the interface.workgroup operations and to gpu.thread_id based on static information available late in the codegen pipeline. Then, it uses -optimize-int-arithmetic to optimize indexing after -lower-affine, getting rid of a bunch of "if the input's negative" logic that isn't actually needed in many of our kernels. It also ensures that these upper_bound values propagate to LLVM.
krzysz00
force-pushed
the
gpu-id-ranges-2
branch
from
dbba7fa to
7edb543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cb5be1d.
Compaled to the previous revision, this one works around a correctness
bug in dataflow analysis that's being fixed by removing the analysis
after SCF->CF.
First, this patch implements InferIntRangeInterface for hal.interface.workgroup.{size,id,count} using a local upper_bound attribute.
Then, it adds a -iree-codegen-gpu-propagate-dispatch-size-bounds pass that adds these upper_bounds identifiers to the interface.workgroup operations and to gpu.thread_id based on static information available late in the codegen pipeline.
Then, it uses -optimize-int-arithmetic to optimize indexing after -lower-affine, getting rid of a bunch of "if the input's negative" logic that isn't actually needed in many of our kernels.
It also ensures that these upper_bound values propagate to LLVM.