Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVMGPU] Drop WorkgroupSpecializationPass #18212

Merged
merged 1 commit into from
Aug 13, 2024
Merged

[LLVMGPU] Drop WorkgroupSpecializationPass #18212

merged 1 commit into from
Aug 13, 2024

Conversation

nirvedhmeshram
Copy link
Contributor

This pass creates control flow in case the tile and distribute phase results in dynamic dimensions. However IREEComprehensiveBufferizePass is capable of handling this later on.

@nirvedhmeshram nirvedhmeshram changed the title [LLVMGPU] Drop WorkgroupSpecializationPass pass [LLVMGPU] Drop WorkgroupSpecializationPass Aug 13, 2024
@nirvedhmeshram nirvedhmeshram force-pushed the drop_WorkgroupSpecializationPass branch from 6f1064b to 2a3afab Compare August 13, 2024 21:47
@nirvedhmeshram nirvedhmeshram force-pushed the drop_WorkgroupSpecializationPass branch from 2a3afab to 9356b65 Compare August 13, 2024 21:55
@nirvedhmeshram nirvedhmeshram marked this pull request as ready for review August 13, 2024 22:27
@MaheshRavishankar MaheshRavishankar added benchmarks:cuda Run default CUDA benchmarks benchmarks:x86_64 Run default x86_64 benchmarks benchmarks:comp-stats Run default compilation statistics benchmarks benchmarks:android-cpu Run default Android CPU benchmarks benchmarks:android-gpu Run default Android GPU benchmarks benchmarks:vulkan-nvidia Run default Vulkan benchmarks on NVIDIA GPU labels Aug 13, 2024
@ScottTodd ScottTodd removed benchmarks:android-cpu Run default Android CPU benchmarks benchmarks:android-gpu Run default Android GPU benchmarks labels Aug 13, 2024
@MaheshRavishankar MaheshRavishankar removed benchmarks:x86_64 Run default x86_64 benchmarks benchmarks:comp-stats Run default compilation statistics benchmarks labels Aug 13, 2024
@nirvedhmeshram nirvedhmeshram merged commit 0c2f51b into iree-org:main Aug 13, 2024
65 of 72 checks passed
@nirvedhmeshram nirvedhmeshram deleted the drop_WorkgroupSpecializationPass branch August 13, 2024 23:23
@nirvedhmeshram nirvedhmeshram mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qedawkins qedawkins qedawkins approved these changes

@MaheshRavishankar MaheshRavishankar MaheshRavishankar approved these changes

@kuhar kuhar Awaiting requested review from kuhar kuhar is a code owner

@Groverkss Groverkss Awaiting requested review from Groverkss Groverkss is a code owner

@antiagainst antiagainst Awaiting requested review from antiagainst antiagainst is a code owner

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW is a code owner

Assignees
No one assigned
Labels
benchmarks:cuda Run default CUDA benchmarks benchmarks:vulkan-nvidia Run default Vulkan benchmarks on NVIDIA GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirvedhmeshram @MaheshRavishankar @qedawkins @ScottTodd