Integrate LLVM at llvm/llvm-project@b0329206 #18102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abbreviated Benchmark Summary@ commit f26aa02a0632f949eaf61baf04ac90268f9d0423 (vs. base 09dc003df2bb3418a71cc36268d2c93adaecebe0) Data-Tiling Comparison TableClick to show
Regressed Latencies 🚩
No improved or regressed compilation metrics 🏖️ For more information: |
Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
hanhanW
force-pushed
the
integrates/llvm-20240805
branch
from
b5d41d5 to
4bc6d1c
Compare
Signed-off-by: hanhanW <[email protected]>
hanhanW
commented
Aug 5, 2024
| @@ -48,7 +48,8 @@ | |||
| #pipeline_layout = #hal.pipeline.layout<push_constants = 1, sets = [ | |||
| <0, bindings = [ | |||
| <0, storage_buffer, ReadOnly>, | |||
| <1, storage_buffer> | |||
| <1, storage_buffer, ReadOnly>, | |||
| <2, storage_buffer> | |||
There was a problem hiding this comment.
I don't know which commit breaks it, but the fix is reasonable to me. It is required by l.183, which has binding(2) while ordinal 2 not present in descriptor set layout. So the fix is adding one more storage_buffer to the set.
// Bindings are accessed by reference.
%binding0 = hal.interface.binding.subspan layout(#pipeline_layout) set(0) binding(0) alignment(64) offset(%c0) : memref<?xf32>{%dim}
%binding1 = hal.interface.binding.subspan layout(#pipeline_layout) set(0) binding(1) alignment(64) offset(%c0) : memref<?xf32>{%dim}
%binding2 = hal.interface.binding.subspan layout(#pipeline_layout) set(0) binding(2) alignment(64) offset(%c0) : memref<?xf32>{%dim}
There was a problem hiding this comment.
Likely unrelated to this LLVM integrate. I thought I had the ASan job running on all (relevant) PRs and commits, but I had a bug. Fix: #18108
ScottTodd
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No local patches.