Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] Do not set lowering_config if they can't share common configs. #14838

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Aug 25, 2023

No description provided.

@dcaballe dcaballe added benchmarks:x86_64 Run default x86_64 benchmarks benchmarks:android-cpu Run default Android CPU benchmarks labels Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Aug 26, 2023

Abbreviated Benchmark Summary

@ commit 7a98e96aafb73df1084d972e812a179be52a6d1a (vs. base 708cf77cdc5510616065355772ef797c8730da6c)

Regressed Latencies 🚩

Benchmark Name Average Latency (ms) Median Latency (ms) Latency Standard Deviation (ms)
EfficientNetV2SPT(linalg) [x86\_64-cascadelake-linux\_gnu-llvm\_cpu][experimental-flags,data-tiling,ukernel] local\_task(embedded\_elf)[8-thread,full-inference,default-flags] with zeros @ c2-standard-16[cpu] 52.477 (vs. 46.784, 12.17%↑) 53.168 3.547

Improved Latencies 🎉

Benchmark Name Average Latency (ms) Median Latency (ms) Latency Standard Deviation (ms)
MobileNetV2\_fp32(tflite) [vmvx-generic-vmvx-vmvx][experimental-flags] local\_task(vmvx\_module)[4-thread,full-inference,system-scheduling] with zeros @ pixel-6-pro[big-core] 4170.617 (vs. 4921.248, 15.25%↓) 4184.884 100.144
EfficientNetV2SPT(linalg) [x86\_64-cascadelake-linux\_gnu-llvm\_cpu][default-flags] local\_task(embedded\_elf)[8-thread,full-inference,default-flags] with zeros @ c2-standard-16[cpu] 42.291 (vs. 47.687, 11.32%↓) 40.612 2.931
MobileNetV3Small\_fp32(tflite) [vmvx-generic-vmvx-vmvx][experimental-flags] local\_task(vmvx\_module)[4-thread,full-inference,system-scheduling] with zeros @ pixel-6-pro[big-core] 890.913 (vs. 987.439, 9.78%↓) 890.177 30.220

[Top 3 out of 5 results showed]

No improved or regressed compilation metrics 🏖️

For more information:

Source Workflow Run

Copy link
Contributor

@dcaballe dcaballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 30, 2023

Can you add a test for this?

I tried when I created the PR, it is quite hard. I can try to prepare one before my vacation, so we can unblock the issue

@hanhanW hanhanW enabled auto-merge (squash) August 31, 2023 23:16
@hanhanW hanhanW merged commit 171e2d1 into iree-org:main Aug 31, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks:android-cpu Run default Android CPU benchmarks benchmarks:x86_64 Run default x86_64 benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants