Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPUPadOperand pass does not work for dynamic shapes #19547

Open
nirvedhmeshram opened this issue Dec 20, 2024 · 1 comment
Open

GPUPadOperand pass does not work for dynamic shapes #19547

nirvedhmeshram opened this issue Dec 20, 2024 · 1 comment

Comments

@nirvedhmeshram
Copy link
Contributor

nirvedhmeshram commented Dec 20, 2024

A fully dynamic mamtmul_transpose_b is lowered to the following dispatch with padding config by TileAndFuse.

Running the following command on it

iree-opt padding_failure.mlir --pass-pipeline="builtin.module(func.func(iree-codegen-gpu-pad-operands))" --debug

gives the following error

Query value bounds for: %44 = flow.dispatch.workload.ordinal %31, 1 : index (owner: flow.dispatch.workload.ordinal)
--> ValueBoundsOpInterface not implemented
[linalg-padding]: ----could not compute a bounding box for padding[linalg-padding]: --operand cannot be bound statically : %extracted_slice = tensor.extract_slice %52[%arg0, 0, 0, 0] [1, 16, %44, 4] [1, 1, 1, 1] : tensor<?x16x?x4xi8> to tensor<1x16x?x4xi8> -> FAIL

Here is the full log

Also here is the full dump from iree-compile.

@nirvedhmeshram
Copy link
Contributor Author

Update on this, only reduction dim has the bounds issue, but since this is after distribute to workgroups bounds can be found on the parallel dims and this works (with a few modifications to the selection code) for static reduction dims

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant