Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code sniffer issues according to Drupal coding standards #15

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

benferch
Copy link

@benferch benferch commented Aug 7, 2024

Fixes code sniffer warnings regarding the Drupal coding standards.

Related to GS1 DGI-1610.

Copy link
Contributor

@martinstadelmann martinstadelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das anfügen der zwei Argumente im Constructor ist ein Breaking-Change:

HP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function Drupal\iq_stage_file_proxy\StreamWrapper\LocalDevPublicStream::__construct(), 0 passed and exactly 2 expected in /project/app/public/modules/custom/iq_stage_file_proxy/src/StreamWrapper/LocalDevPublicStream.php:57
Stack trace:
#0 [internal function]: Drupal\iq_stage_file_proxy\StreamWrapper\LocalDevPublicStream->__construct()
#1 /project/app/public/modules/contrib/google_tag/src/Entity/ContainerManager.php(267): is_dir()
#2 /project/app/public/modules/contrib/google_tag/src/Entity/ContainerManager.php(254): Drupal\google_tag\Entity\ContainerManager->deleteAssets()
#3 /project/app/public/modules/contrib/google_tag/google_tag.module(62): Drupal\google_tag\Entity\ContainerManager->deleteAllAssets()
#4 /project/app/public/modules/contrib/google_tag/google_tag.module(42): _google_tag_assets_delete()
#5 [internal function]: google_tag_rebuild()
#6 /project/app/public/core/lib/Drupal/Core/Extension/ModuleHandler.php(409): call_user_func_array()
#7 /project/app/public/core/lib/Drupal/Core/Extension/ModuleHandler.php(388): Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}()
#8 /project/app/public/core/lib/Drupal/Core/Extension/ModuleHandler.php(408): Drupal\Core\Extension\ModuleHandler->invokeAllWith()
#9 /project/app/public/core/includes/common.inc(477): Drupal\Core\Extension\ModuleHandler->invokeAll()
#10 /project/app/public/core/includes/utility.inc(41): drupal_flush_all_caches()
#11 /project/app/vendor/drush/drush/src/Commands/core/CacheRebuildCommands.php(70): drupal_rebuild()
#12 [internal function]: Drush\Commands\core\CacheRebuildCommands->rebuild()
#13 /project/app/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#14 /project/app/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#15 /project/app/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#16 /project/app/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process()
#17 /project/app/vendor/symfony/console/Command/Command.php(326): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#18 /project/app/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run()
#19 /project/app/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand()
#20 /project/app/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun()
#21 /project/app/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run()
#22 /project/app/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#23 /project/app/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run()
#24 /project/app/vendor/drush/drush/drush(4): require('...')
#25 /project/app/vendor/bin/drush(119): include('...')
#26 {main}

Werde das gleich noch in eurem Projekt zurückmelden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants