Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Ledger support #292

Closed
tony-iqlusion opened this issue Feb 5, 2021 · 4 comments
Closed

Deprecating Ledger support #292

tony-iqlusion opened this issue Feb 5, 2021 · 4 comments

Comments

@tony-iqlusion
Copy link
Member

tony-iqlusion commented Feb 5, 2021

HEADS UP: THE LEDGER VALIDATOR APP WILL NOT WORK ON TENDERMINT V0.34 NETWORKS INCLUDING STARGATE

Note that the Ledger Validator App performs consensus signing and is different from the Ledger Cosmos App which is a wallet application unrelated to TMKMS.

After some discussion about what to do about #212, we have come to the conclusion that there is little interest in the Ledger Validator App, nor have we been able to find anyone who is actually using it in production.

To update the app for Tendermint v0.34/Stargate compatibility (which uses new message formats and signing algorithms), we would need to find financing to hire a Ledger developer to do the update work. This has not happened and there seems to be a general lack of interest.

Based on that, barring any input to the contrary and financing of the app's ongoing development to retain compatibility, we intend to deprecate Ledger support and remove it from a future TMKMS release.

@jleni
Copy link
Contributor

jleni commented Feb 6, 2021

In 2017, Zondax developed this Ledger app for Interchain to provide double-sign protection directly inside the HSM. While not ideal, given that Ledger Nano S devices are consumer devices, at the time it was a very low cost solution accesible to everyone. Several validators started to use it immediately.

We understand that over the years, for different reasons, the validator community may have opted to use alternative approaches. In fact, we were not actively involved in promoting its use. Nevertheles, we hope that over time, the amount of validators using keeping keys in cloud hosts or blind HSMs will decrease.

In any case, if there is any need, we are happy to update both the integration and apps. Moreover, in the next few months we are planning to release something cool that would actually provide a great alternative and we may consider including Tendermint/Stargate support to it. Stay tuned!

@cwgoes
Copy link

cwgoes commented Feb 9, 2021

Cryptium presently uses the Ledger validator application in production with a physical host and device. Sorry for the late response. Thanks for your efforts building & maintaining it. If there is no interest from other validators, we are probably not enough of a reason to continue supporting the app, and we can find alternative solutions.

@jleni
Copy link
Contributor

jleni commented Feb 9, 2021

Let me know if you need any help. I think this is something that should be very easy based on what I discussed with Marko. We can talk to Billy and get it done quickly I think.

@tony-iqlusion
Copy link
Member Author

Okay, if there's interest in keeping it around we won't deprecate it.

I'll close this and reopen #212 for tracking progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants