-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primers contributing to Clean.Tot.cons #100
Comments
The primer id stage before cylon is different than what is used for masking the consensus. When an adjacent amplicon is dropped the overhanging primer bases will be considered, so we would expect those reads to contribute to Are there examples where this happens when the adjacent amplicon is not dropped? |
This issue has nothing to do with cylon. It's about when primer parts of reads are used to contirbute to good or bad coverage for masking, and in the stats. We have sequence chunks like this in the amplicon from left to right: L = left chunk (I don't care about left primers here) and the subsequent amplicon is dropped. I would expect that the P1 part of the reads that were made during PCR from P1 do not count towards the good depth, since there should be reads that arose from P2 during PCR. Those reads from P2 should also include the P1 sequence and can be relied upon for their P1 sequence. |
I'm sorry I don't quite understand. How does this differ from what we're doing right now? |
Current behaviour: Expected behaviour: |
P1 and P2 are alts on the same side of an amplicon, right? Do you have an example? |
this simulation is the example @jeff-k |
In #99's example we are adjacent to a missing amplicon. This means that primer bases will be considered no matter what. I'm not sure how we can determine that the current behaviour is deviating from the expected behaviour. |
We have examples where there is an amplicon with two right-hand primers. Neither primer is excluded at the primer/amplicon identification stage, and both are provided to cylon.
Observed behaviour: in
all_stats.tsv
, at the "inner" (or left most, whatever you want to call it) right-hand primer position, the reads from the "inner primer" are contributing toClean.Tot.cons
.Expected behaviour: those reads do not contribute to
Clean.Tot.cons
.An example is #99 , in amplicon
SARS-CoV-2_76
.This may be confounded by the adjacent amplicon 77 being dropped, I don't know. The behaviour below may also be happening when the adjacent amplicon is not dropped - this needs checking.
For the sample in #99 this is what happens:
SARS-CoV-2_76
are excluded (a separate issue to this one)SARS-CoV-2_76_RIGHT
(coords 23029-23057).SARS-CoV-2_76_RIGHT
. The primer is not (as far as the code knows) at the end of the amplicon - the decision earlier was to also keepSARS-CoV-2_76_RIGHT_alt1
(coords 23121-23141).all_stats.tsv
reports non-zeroClean.Tot.cons
values at 23029-23057 - they are fairly close to the values inRawDepth
.The text was updated successfully, but these errors were encountered: