You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The script converts Jupyter notebooks into Python scripts that our CI can execute, to make sure that our notebooks work correctly. For more about our use-case, refer to the PR that added it: syne-tune/syne-tune#756
We have been using traitlets to skip specific Jupyter notebook cells that have been tagged with a special ci-skip-cell tag (example). The reason for skipping specific cells is because we found that attempting to convert notebooks with %pip install cells did not work. What we are doing is instead installing the dependencies ahead of time in our CI environment, and then running the rest of the converted script.
Problem
Before the update to 5.12.0, running the conversion script would skip the cells tagged with ci-skip-cell, however after the update, the cells have stopped being skipped.
Context
I noticed that a script that we use as part of our CI workflow stopped working with the update from traitlets
5.11.2
to5.12.0
.The script in question: https://github.com/awslabs/syne-tune/blob/main/.github/workflows/utils/notebooks2scripts.py#L8
Relevant lines:
The script converts Jupyter notebooks into Python scripts that our CI can execute, to make sure that our notebooks work correctly. For more about our use-case, refer to the PR that added it: syne-tune/syne-tune#756
We have been using traitlets to skip specific Jupyter notebook cells that have been tagged with a special
ci-skip-cell
tag (example). The reason for skipping specific cells is because we found that attempting to convert notebooks with%pip install
cells did not work. What we are doing is instead installing the dependencies ahead of time in our CI environment, and then running the rest of the converted script.Problem
Before the update to
5.12.0
, running the conversion script would skip the cells tagged withci-skip-cell
, however after the update, the cells have stopped being skipped.Converted script before updating:
Converted notebook after the update:
Note the two additional
get_ipython
lines that we do not want to see.PR reverting to
5.11.2
makes all of the test pass again: syne-tune/syne-tune#782Example test run where they were failing: https://github.com/awslabs/syne-tune/actions/runs/6693658169
Question
Is the new traitlets behavior expected?
The text was updated successfully, but these errors were encountered: