Gracefully recover from nested value-key marshalling #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behaviour of value-key merger in certain scenarios may have been resulted in value-keys being marshalled repeatedly. This was the underlying cause of the issue captured in #94 and corrected in #95. The work here adds to the corrections by gracefully fixing such records by unmarshalling them recursively until we reach values with the expected key prefix, and de-duplicating them as necessary. The fix is done opportunistically, in that whenever such values are detected during reads and writes they are fixed. Additional tests are added to simulate nested marshalling of value-keys and assert that the resulting merge is as expected for both merge-older and merge-newer cases.
|
Workload 0 benchmark results: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 63.47% 63.61% +0.13%
==========================================
Files 15 15
Lines 2779 2803 +24
==========================================
+ Hits 1764 1783 +19
- Misses 753 757 +4
- Partials 262 263 +1
|
ischasny
reviewed
Oct 6, 2022
| if _, pendingDelete := v.deletes[string(value)]; pendingDelete { | ||
| return true | ||
| } | ||
| for _, x := range v.merges { |
There was a problem hiding this comment.
How many elements do you expect to be in v.merges? Would it make sense to have an additional hashtable to avoid full scan?
There was a problem hiding this comment.
The reason for not using a map to store merges is that we need to maintain the insertion order. Iteration order over map in Golang is non-deterministic I'm afraid.
ischasny
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour of value-key merger in certain scenarios may have been resulted in value-keys being marshalled repeatedly. This was the underlying cause of the issue captured in #94 and corrected in #95.
The work here adds to the corrections by gracefully fixing such records by unmarshalling them recursively until we reach values with the expected key prefix, and de-duplicating them as necessary. The fix is done opportunistically, in that whenever such values are detected during reads and writes they are fixed.
Additional tests are added to simulate nested marshalling of value-keys and assert that the resulting merge is as expected for both merge-older and merge-newer cases.