Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the term serde to codec #66

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Rename the term serde to codec #66

merged 2 commits into from
Aug 18, 2022

Conversation

masih
Copy link
Member

@masih masih commented Aug 18, 2022

Rename to a more familiar term for better human readability.

masih added 2 commits August 18, 2022 18:33
Rename to a more familiar term for better human readability.
@masih masih requested a review from gammazero August 18, 2022 17:34
@github-actions
Copy link

Suggested version: v0.5.0
Comparing to: v0.4.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# github.com/filecoin-project/go-indexer-core
## incompatible changes
BinaryValueSerde: removed
ErrSerdeOverflow: removed
JsonValueSerde: removed
ValueSerde: removed
## compatible changes
BinaryValueCodec: added
ErrCodecOverflow: added
JsonValueCodec: added
ValueCodec: added

# github.com/filecoin-project/go-indexer-core/store/pogreb
## incompatible changes
New: changed from func(string, github.com/filecoin-project/go-indexer-core.ValueSerde) (github.com/filecoin-project/go-indexer-core.Interface, error) to func(string, github.com/filecoin-project/go-indexer-core.ValueCodec) (github.com/filecoin-project/go-indexer-core.Interface, error)

# github.com/filecoin-project/go-indexer-core/store/storethehash
## incompatible changes
New: changed from func(context.Context, string, github.com/filecoin-project/go-indexer-core.ValueSerde, ...github.com/ipld/go-storethehash/store.Option) (github.com/filecoin-project/go-indexer-core.Interface, error) to func(context.Context, string, github.com/filecoin-project/go-indexer-core.ValueCodec, ...github.com/ipld/go-storethehash/store.Option) (github.com/filecoin-project/go-indexer-core.Interface, error)

# summary
Suggested version: v0.5.0

gocompat says:

(empty)

@masih masih merged commit 6f4e066 into main Aug 18, 2022
@masih masih deleted the masih/rename-serde-to-codec branch August 18, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants