Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to log the list of Boxo/Kubo commits in master/main that aren't making it into a release #6

Closed
BigLep opened this issue May 18, 2023 · 3 comments · Fixed by #15

Comments

@BigLep
Copy link

BigLep commented May 18, 2023

Done Criteria

The releaser sees the list of Boxo and Kubo commits that are in master/main that aren't being included in the current release.
The release issue is also updated with this information.

Why Important

Especially now that fixes are often made in Boxo but need to be bubbled up to Kubo, it's easier to have a Kubo release not include all the desired functionality. We had this in happen in 0.20 (see here). This either frustrates users and/or creates extra work for the maintainers having to do extra followup releases.

Notes

I hypothesize that seeing this list and having it get added to the release issue (which others are subscribed to) will help trigger if we're missing something important.

@BigLep
Copy link
Author

BigLep commented May 18, 2023

@galargh : if possible, I'd like to improve this before 0.21. Also, if you have better ideas on how to do this rather than printing to console and posting to the release issue, feel free to share.

@BigLep
Copy link
Author

BigLep commented Jul 18, 2023

@galargh : this is awesome - thank you!

I want to make sure that someone not executing the release will still have visibility into this set of commits that aren't included. If I understand correctly, the set of commits will make it into the release PR description. The release PR also references the release issue (which causes a backlink from the release issue to the release PR). As a result, it should be self-service for someone to discover and see this easily enough. Correct me if I have this wrong.

Thank you!

@galargh
Copy link
Contributor

galargh commented Jul 19, 2023

Yes! That's exactly right. The release PR is linked to the release issue so it should be quite easy for anyone to get to this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants