Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cmd/ipfs: Make it possible to depend on cmd/ipfs #9782

Closed
wants to merge 3 commits into from

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 30, 2023

Today there are two ways to run kubo with plugins, one on non-linux systems:

  • Preload - which requires the plugin to be in the kubo repo, or at least requires manual build of kubo
  • Use a Go plugin, which don't work on most systems, and won't work if any build dependency isn't perfectly aligned - which in practice makes them almost completely unusable for anything non-trivial

This PR adds a third way - by depending on cmd/ipfs/kubo it's now possible to depend on this repo to create kubo-derived nodes with user-specified plugins.

I needed this for RIBS, which is a highly-advanced blockstore, that couldn't justifiably "just be integrated" into upstream kubo.

Review probably easiest commit-by-commit.

@guseggert
Copy link
Contributor

This looks like a much better way to inject plugins than the standard practice of modifying the preloads and rebuilding kubo bin. What are the drawbacks to this?

@BigLep
Copy link
Contributor

BigLep commented Apr 19, 2023

@guseggert : maybe this is something you and @magik6k can discuss in person at IPFS Thing 2023?

@BigLep
Copy link
Contributor

BigLep commented May 18, 2023

2023-05-18 maintainer conversation: all agreed this should get done for the next release. We haven't assigned an owner yet. A doc update should be made to https://github.com/ipfs/kubo/blob/master/docs/customizing.md as well.

@magik6k
Copy link
Member Author

magik6k commented Jun 29, 2023

fyi the other branch - https://github.com/ipfs/kubo/compare/magiks-ribs-hacks - is now up to date with master. May make sense to swap this PR to that one

@BigLep BigLep mentioned this pull request Aug 3, 2023
@BigLep BigLep mentioned this pull request Nov 9, 2023
11 tasks
@Stebalien
Copy link
Member

Replaced by #10219.

@Stebalien Stebalien closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants