Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreapi: Split the interface into multiple files #4802

Merged
merged 5 commits into from
Mar 23, 2018
Merged

coreapi: Split the interface into multiple files #4802

merged 5 commits into from
Mar 23, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 10, 2018

The interface file has become quite crowed now, splitting it helps a lot.

magik6k added 4 commits March 10, 2018 18:27
@magik6k
coreapi: move unixfs errors to the top
20b59ec 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
coreapi: don't alias ipld types
eff69bb 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
coreapi: split the interface into multiple files
f218b69 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
coreapi: minor doc fixes
fa0fef3 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k magik6k requested a review from Kubuxu as a code owner March 10, 2018 18:31
@ghost ghost assigned magik6k Mar 10, 2018
@ghost ghost added the status/in-progress In progress label Mar 10, 2018
This was referenced Mar 10, 2018
Merged
Merged
Merged
Kubuxu
Kubuxu reviewed Mar 10, 2018
View reviewed changes
core/coreapi/interface/errors.go Outdated
import "errors"

var ErrIsDir = errors.New("object is a directory")
var ErrOffline = errors.New("can't resolve, ipfs node is offline")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: var block might be cleaner here.

@magik6k
coreapi: var block for errors
e54a4f8 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@Kubuxu Kubuxu self-requested a review March 10, 2018 22:35
@magik6k magik6k added the topic/core-api Topic core-api label Mar 11, 2018
@magik6k magik6k mentioned this pull request Mar 11, 2018
Merged
@Kubuxu Kubuxu requested a review from Stebalien March 12, 2018 21:18
Stebalien
Stebalien approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any changes here other than simply documenting and splitting things up into multiple files? Diffs make hard to to tell. If not, LGTM (although I didn't read the diff thoroughly).

@magik6k
Copy link
Member Author

magik6k commented Mar 12, 2018

The only API change other than splitting the interface into multiple files is the removal of mirrored Node/Link types - https://github.com/ipfs/go-ipfs/pull/4802/files#diff-a8303f091bce9826ba705d0eb8465cc7L30. It didn't really help with anything and only made using/implementing the api require constantly casting things.

@Kubuxu Kubuxu added this to the go-ipfs 0.4.15 milestone Mar 12, 2018
@Kubuxu Kubuxu added RFM and removed status/in-progress In progress labels Mar 12, 2018
@whyrusleeping whyrusleeping merged commit e99b91a into master Mar 23, 2018
@whyrusleeping whyrusleeping deleted the feat/coreapi/split-iface branch March 23, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Stebalien Stebalien Stebalien approved these changes

Assignees

@magik6k magik6k

Labels
RFM topic/core-api Topic core-api
Projects
None yet
Milestone
go-ipfs 0.4.15
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @Stebalien @whyrusleeping @Kubuxu