Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-datastore changes 0.1.2 #2933

Merged
merged 1 commit into from
Jul 2, 2016
Merged

Conversation

whyrusleeping
Copy link
Member

@kevina these are mostly your changes to the query code

License: MIT
Signed-off-by: Jeromy [email protected]

License: MIT
Signed-off-by: Jeromy <[email protected]>
@Kubuxu
Copy link
Member

Kubuxu commented Jul 2, 2016

LGTM (I have to reabase onto it).

@kevina
Copy link
Contributor

kevina commented Jul 2, 2016

LGTM.

Note that there may still be room to improve "ipfs refs local" (for example find . -name '*.data' is still faster), but this simple change should not cause any problems.

@whyrusleeping
Copy link
Member Author

@kevina some of the cost of refs local is base58 encoding, that shit is expensive.

@whyrusleeping whyrusleeping merged commit 4fa85cc into master Jul 2, 2016
@whyrusleeping whyrusleeping deleted the deps/update-datastore/0.1.2 branch July 2, 2016 06:14
@kevina
Copy link
Contributor

kevina commented Jul 2, 2016

@whyrusleeping Sorry ipfs refs local was not made to be taken literally, my benchmark code in ipfs/go-datastore#40 does not attempt to decode the key using base58 and my very informal tests found find . -name '*.data' faster then than the direct method on the graph. I did not report it because it was very informal test.

@whyrusleeping
Copy link
Member Author

@kevina ah! gotcha, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants