-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for v0.4.2 #2714
Add changelog for v0.4.2 #2714
Conversation
* Set a deadline for dialing attempts. This prevents a node from accumulating | ||
failed connections. (@whyrusleeping) | ||
* Avoid unneccessary string/byte conversions in go-multihash. (@whyrusleeping) | ||
* Fix a deadlock around the yamux stream muxer. (@whyrusleeping) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be good to start linking to the various issues, shrug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entries here often don't match one-to-one with a PR -- but I agree that for the interesting changes it'd be pretty useful.
Next time? :) Or I can give it another go tomorrow.
* Documentation | ||
* Add a debug-guidelines document. (@richardlitt) | ||
* Update the contribute document. (@richardlitt) | ||
* Fix documentation of all `ipfs` commands. (@richardlitt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be more detailed than this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about: Improved default documentation and logic for most
ipfscommand options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok cool, suggestions? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, what is this meant to be for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be split into "Fix default values of many ipfs
commands" and "Improve commands documentation"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we cover that below. What were you referring to in this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved.
3ed82aa
to
ef07b20
Compare
LGTM. I think its time to hop on the release train! |
License: MIT Signed-off-by: Lars Gierth <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
This is good to go |
Everybody PTAL -- did I overlook anything?