build: specify a dist.ipfs.io hash #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now bin/dist_get trusts whatever DNS resolver is active. This change enables it to verify what it downloads. Verification itself remains TODO. This will work best with a unixfs-hash tool which is TODO too. It'd just do the equivalent of `ipfs add -n -r <dirOrFile>`. License: MIT Signed-off-by: Lars Gierth <[email protected]>
|
Also enables SSL there |
|
Very nice! LGTM |
|
@whyrusleeping thoughts? |
ghost
mentioned this pull request
|
@lgierth this LGTM, mind changing this at https://github.com/whyrusleeping/dist_get too? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: specify a dist.ipfs.io hash
Right now bin/dist_get trusts whatever DNS resolver is active.
This change enables it to verify what it downloads.
Verification itself remains TODO.
This will work best with a unixfs-hash tool which is TODO too.
It'd just do the equivalent of
ipfs add -n -r <dirOrFile>.License: MIT
Signed-off-by: Lars Gierth [email protected]