Cleaned up ipfs id mans
#2285
Cleaned up ipfs id mans
#2285
Conversation
| @@ -19,7 +19,7 @@ import ( | |||
| u "github.com/ipfs/go-ipfs/util" | |||
| ) | |||
|
|
|||
| const offlineIdErrorMessage = `ID command fails when run without daemon, we are working to fix this. | |||
| const offlineIdErrorMessage = `Id command fails when run without the daemon; we are working to fix this. | |||
There was a problem hiding this comment.
huh, this is no longer true. You can run ipfs id without a running daemon just fine
There was a problem hiding this comment.
Yeah. You don't even use the daemon anymore; it doesn't hit it at all.
There was a problem hiding this comment.
mind removing this in this PR?
RichardLitt
force-pushed
the
docs/cleanup-id-mans
branch
from
babd707
to
d5153db
Compare
|
okay, after seeing the test failures and looking into it a little more, i see why we had that message. Its for if we try to |
|
@RichardLitt rewrote that error message in a way that makes more sense to me. Wanna look it over? |
| In the meantime, please run the daemon if you want to use 'ipfs id': | ||
| const offlineIdErrorMessage = `'ipfs id' currently cannot query information on remote | ||
| peers without a running daemon; we are working to fix this. | ||
| In the meantime, please run the daemon if you want to use 'ipfs id' in that way: |
There was a problem hiding this comment.
"In the meantime, if you want to query remote peers using 'ipfs id', please run the daemon:"
License: MIT Signed-off-by: Richard Littauer <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
docs/cleanup-id-mans
branch
from
8202a00
to
15d827b
Compare
|
LGTM. Might clash with #2300. |
Cleaned up `ipfs id` mans
|
@RichardLitt wanna rebase #2300? |
|
@whyrusleeping Done! |
License: MIT
Signed-off-by: Richard Littauer [email protected]