-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stdin parsing optional arg #1263
Merged
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There can be non-terminal (i.e. non-interactive) sessions that are *not* a pipe, for example: ssh user@host ipfs version In this case, it looks like we should read from stdin. Parsing stdin is accomplished by deliberately triggering the parsing loop once. We didn't previously check whether there is an ArgDef to support that loop iteration.
License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
ghost
mentioned this pull request
May 20, 2015
This works for me, thx @lgierth and @chriscool for unblocking me! |
LGTM. will merge after tests |
(any year now) |
There are some sharness test errors in the Travis PR build but they are not related:
|
thanks @chriscool and @lgierth ! |
chriscool
added a commit
that referenced
this pull request
May 22, 2015
This issue has been fixed by merging PR #1263 or PR #1238. License: MIT Signed-off-by: Christian Couder <[email protected]>
This was referenced May 22, 2015
chriscool
added a commit
that referenced
this pull request
May 22, 2015
This issue has been fixed by merging PR #1263 or PR #1238. License: MIT Signed-off-by: Christian Couder <[email protected]>
Closed
ghost
mentioned this pull request
Jan 2, 2016
ghost
mentioned this pull request
May 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #1260 (Ipfs crashes when run as a node subprocess).
This is based on top of @lgierth 's PR #1255 (parse: fix handling of unwanted stdin) as it modifies the same line of code.