Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI isn't failing for go tests that don't compile #6320

Closed
Stebalien opened this issue May 11, 2019 · 3 comments · Fixed by #6362
Closed

CI isn't failing for go tests that don't compile #6320

Stebalien opened this issue May 11, 2019 · 3 comments · Fixed by #6362
Assignees

Comments

@Stebalien
Copy link
Member

See: #6319

Any ideas?

@cbuesser
Copy link
Contributor

I think this is happening because your

$ make -j 1 test/unit/gotest.junit.xml \
$ && [[ ! $(jq -s -c 'map(select(.Action == "fail")) | .[] test/unit/gotest.json) ]] 

is returning a 0 when it fails to parse a:

FAIL github.com/ipfs/go-ipfs/cmd/ipfs/util [build failed]

line in the test/unit/gotest.json

@magik6k
Copy link
Member

magik6k commented May 14, 2019

That looks like a go test bug

@magik6k
Copy link
Member

magik6k commented May 14, 2019

golang/go#23037, we can implement a work around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants